By: Johnno Nolan (@JohnnoNolan)
Code smells are a great metaphor to describe potential design problems but in my mind they have exactly the same issues as design patterns. Sometimes in code reviews these labels can be used without...
View ArticleBy: mikewoodhouse
I attended one of Jim’s connascence talks a couple of years back, during which I had a similar thought. I managed to speak to him briefly after and he agreed that some classes of smells seemed to...
View ArticleBy: Kevin Rutherford
I ran a little exercise in one of my taught classes yesterday asking just that question. The groups did find some relationships, but most were not clear.
View ArticleBy: Seb Rose
I don’t think that your reasons stack up well. Many of the same objections could be levelled against patterns, if you were to ignore the context and forces sections. There are also certainly cases...
View ArticleBy: Kevin Rutherford
Fair comment. I think smells /are/ patterns, but haven’t always been treated with the same formality of structure. And while I’d like them to be a “placeholder”, I don’t see people holding them in that...
View ArticleBy: Matt (@DaftDuck22)
Code smells just tell you what not to do. They don’t really tell you how to go about dealing with the smell. Using connascence gives you a direction for improvement (refactor to a lesser form of...
View ArticleBy: xpmatteo
I found that in practice, it’s not true that (as an enthusiastic Kent Beck or Ron Jeffries said a while ago) all the design books you need to do XP is the TDD book and the Refactoring book. I...
View ArticleBy: Kevin Rutherford
@xpmatteo I agree completely. Maybe someone needs to write a #goos workbook :)
View ArticleBy: hgs
Reading the second paragraph I thought the list was about the metaphor. My list started out as: a smell can be hard to trace when it is strong; when the problem is fixed, the smell can remain; to track...
View ArticleBy: Eldan
Feature Envy differs from Inappropriate Intimacy in that when you have Feature Envy it’s obvious that you’re accessing the public members/methods of another class, inappropriate is when it’s really...
View ArticleBy: A problem with Primitive Obsession | silk and spinach
[…] general I’m finding that connascence is better than code smells as a tool for discussing coupling. And in particular, it seems to me that Primitive […]
View ArticleBy: Steve Tooke (@tooky)
I like the idea that looking for connascence can help us find suboptimal design. I’ve written an example up that I think shows how looking at connascence can help....
View Article
